search

infusionsoft / bower-locker

Command line tool to create a pseudo-bower lock file.
Apache License 2.0
15 stars 8 forks source link

Bower-locker gets directory location from .bowerrc #4

Closed coolynx closed 7 years ago

coolynx commented 8 years ago

Would be nice if bower-locker could read the bower config .bowerrc file and find there bower_components directory variable.

{
  "directory": "vendor/bower_components"
}

Right now it throws an error because the components path is hardcoded.

env: node\r: No such file or directory

shawnlonas commented 8 years ago

@coolynx , great suggestion.

At the moment, our internal projects use the default setting but if you can provide a pull request we would be happy to review and incorporate it into the project for everyone.

coolynx commented 8 years ago

Thank you for an offer! But I'm not that good at programming. 😆

After reading more about Bower, looks like it is not the best tool to use. So it is not useful to make more hacks and workarounds around hacks and workarounds. 😏

In my case I guess it is necessary to learn how to use npm shrinkwrap.

Sorry for disturbing and thank your for your time! 👍

KristofMorva commented 7 years ago

Solved in #6

shawnlonas commented 7 years ago

Thanks @kmorva !