infusionsoft / infusionsoft-php

PHP client library for the Infusionsoft API.
https://developer.infusionsoft.com/
Other
130 stars 128 forks source link

Rename RestApi.php to AbstractApi.php #244

Closed ellisio closed 4 years ago

ellisio commented 4 years ago

This will resolve the deprecation warning issued by Composer.

Deprecation Notice: Class Infusionsoft\Api\Rest\AbstractApi located in ./vendor/infusionsoft/infusionsoft-sdk/src/Infusionsoft/Api/Rest/RestApi.php does not comply with psr-0 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/Cellar/composer/1.10.0/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:185
ghost commented 4 years ago

Hello.

The file src/Infusionsoft/Api/Rest/RestApi.php is not used within the source code. It should be removed instead of renamed. I believe this file is the old version of src/Infusionsoft/Api/AbstractApi.php but it just haven't been removed.

ellisio commented 4 years ago

Hello.

The file src/Infusionsoft/Api/Rest/RestApi.php is not used within the source code. It should be removed instead of renamed. I believe this file is the old version of src/Infusionsoft/Api/AbstractApi.php but it just haven't been removed.

@overrid310 This PR was to do this rename. Looks like that was already done.

Abhi0725 commented 3 years ago

Is this already done? I am on the latest 1.5.1 and still getting psr-0 autoload issue.