search

ing-bank / baker

Orchestrate microservice-based process flows
https://ing-bank.github.io/baker/
MIT License
330 stars 82 forks source link

Type handling in Kotlin DSL still had a bug #1745

Closed jwalgemoed closed 1 week ago

jwalgemoed commented 1 week ago

Bug surfaced when declaring recipe ingredients or functioninteractioninstances using the Kotlin DSL that contained optionals, but chances are all generic wrappers are affected. Patch to resolve this.

codecov-commenter commented 1 week ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.45%. Comparing base (18aa9af) to head (0d8f366). Report is 1 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1745 +/- ## ======================================= Coverage 79.45% 79.45% ======================================= Files 144 144 Lines 5009 5009 Branches 674 674 ======================================= Hits 3980 3980 Misses 1029 1029 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jwalgemoed commented 1 week ago

Small patch, adding javaTypeOf<T>() function to get to the javatype for classes instead of having to use typeOf<T>().javaType.