ing-bank / cassandra-jdbc-wrapper

A JDBC wrapper of Java Driver for Apache Cassandra®, which offers a simple JDBC compliant API to work with CQL3.
Apache License 2.0
70 stars 25 forks source link

Support consistency level statements #56

Closed kornilova203 closed 4 months ago

kornilova203 commented 4 months ago

This MR supports CQL shell consistency statements https://docs.datastax.com/en/cql-oss/3.x/cql/cql_reference/cqlshConsistency.html

CONSISTENCY [level] and CONSISTENCY

It's convenient to have an option to change consistency level from cql instead of changing jdbc parameters and opening new connection

Implementation of ListResultSet is basic

maximevw commented 4 months ago

Hello @kornilova203

Thanks again for your contributions!

This feature is interesting. But, before deep-diving into this review, I'd like to discuss some points globally:

maximevw commented 4 months ago

Thank you @kornilova203 for fixing the tests. When you'll have time, I'll let you discuss my other comments, especially the first and third points of the list.

kornilova203 commented 4 months ago

@maximevw, thanks a lot for the review! Those all are fair points But I unfortunately don't have enough time to work on this branch at the moment, so I'll just close the review

maximevw commented 4 months ago

Ok, no problem @kornilova203. I keep the idea and I'll try to re-implement this for the next version, based on your work.

maximevw commented 3 months ago

For information @kornilova203, this has been implemented in the commit https://github.com/ing-bank/cassandra-jdbc-wrapper/commit/26d59a09d5668fa93ca79a57c8314b3e30a99665. This could be re-used as a basis to implement other interesting commands in the future: