search

ing-bank / lion

Fundamental white label web component features for your design system.
https://lion-web.netlify.app/
MIT License
1.75k stars 293 forks source link

fix(slotmixin): Now throws shadowRoot not found in case of shadowRoot… #2291

Closed Dozom closed 4 months ago

Dozom commented 4 months ago

… equals to null

What I did

  1. I throw an error if shadowRoot was not found.
changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: 69150cfd54bd82e74eaa3047bb2e709893f6110a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------- | ----- | | @lion/ui | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

CLAassistant commented 4 months ago

CLA assistant check
All committers have signed the CLA.

Dozom commented 4 months ago

Hello @tlouisse! It was my first contribution to open source,

  1. When do I have to execute npm run changelog, after pulling the changes or before?
  2. How can I add the changelog?

Actual step (local fork):

image

It created a .changeset/odd-poets-grow.md with the following content,

'@lion/ui': major

fix(slotmixin): Now prints a console error when shadowRoot is not found

What is this used for?

Thank's for the answer!

tlouisse commented 4 months ago

Hi @Dozom

  1. When do I have to execute npm run changelog, after pulling the changes or before?

It's a good practice to attach a changeset entry to a commit(npm run changeset writes an md file to the .changesets folder).

  1. How can I add the changelog?

This is done automatically in a separate pipeline (@changeset/cli generates the changelog based on the changeset files: https://github.com/changesets/changesets?tab=readme-ov-file)

Dozom commented 4 months ago

Hi @tlouisse I added the changeset entry, is it correct? On the other hand, thank's for documentation I really appreciated. 😄

tlouisse commented 4 months ago

Hi @tlouisse I added the changeset entry, is it correct? On the other hand, thank's for documentation I really appreciated. 😄

Yes, looks good. Thanks for the contribution!