fix: add files more than once doesn't overwrite anymore - Githubissues

ing-bank / lion

Fundamental white label web component features for your design system.

https://lion-web.netlify.app/

MIT License

1.75k stars 293 forks source link

fix: add files more than once doesn't overwrite anymore #2308

Closed ryubro closed 3 months ago

ryubro commented 3 months ago

What I did

Fixed a bug that when user adds files more than once, the model value is overwritten by the last addition but the file list grows, adding the last addition to the existing list
- Example: User added two files, a and b in a file dialog, then added another file c opening a file dialog once more. The file list would have a, b, c but the model value would be c. After the fix, the model value also would be a, b, c.
- Tested on both dialog and drag & drop

[x] Fixing an issue when we upload the same file, the model value gets empty.

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 5917423bc9d14164fe7ee98e808a4ad5d24ca226

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | -------- | ----- | | @lion/ui | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

CLAassistant commented 3 months ago

All committers have signed the CLA.

ryubro commented 3 months ago

Done ~~Fixing an issue when we upload the same file, the model value gets empty.~~