search

ing-bank / lion

Fundamental white label web component features for your design system.
https://lion-web.netlify.app/
MIT License
1.75k stars 293 forks source link

fix(overlays): prevent closing of a modal dialog on pressing Esc and … #2310

Closed gerjanvangeest closed 2 months ago

gerjanvangeest commented 3 months ago

…hidesOnEsc is set to false

What I did

  1. prevent the default when the cancel event was fired, so that hidesOnEsc: false works.
changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: f9ba215675ff2282b96887538c8d4c1919ef0a55

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------- | ----- | | @lion/ui | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

tlouisse commented 2 months ago

Nice 👍