fix(report): text contrast and consistent yellow traffic light

ing-bank / popmon

Monitor the stability of a Pandas or Spark dataframe ⚙︎

https://popmon.readthedocs.io/

MIT License

495 stars 35 forks source link

fix(report): text contrast and consistent yellow traffic light #209

Closed sbrugman closed 2 years ago

sbrugman commented 2 years ago

Fix contrast in text of alert section
Use consistent yellow/orange throughout the report for traffic lights

tomcis commented 2 years ago

Is there any visual change that I should observe here? Did not see much difference after the visual inspection.

sbrugman commented 2 years ago

@tomcis The text color for the alert section should now be light when the background is darker. The other change is that we used to use different colors of red and yellow/orange throughout the report. With this PR all are exactly the same color.

tomcis commented 2 years ago

Yes, see it now - looks good! Thanks for the elaboration.