ing-bank / popmon

Monitor the stability of a Pandas or Spark dataframe ⚙︎
https://popmon.readthedocs.io/
MIT License
493 stars 33 forks source link

Pydantic is not pinned in pyproject.toml or requirements.txt #274

Closed miguelpher closed 1 year ago

miguelpher commented 1 year ago

Pydantic has recently been updated to v2.0 (2023-06-30), but it is not pinned in pyproject.toml or requirements.txt. Could you please either update it or pin the version?

File "..../lib/python3.10/site-packages/popmon/config.py", line 24, in <module>
    from pydantic import BaseModel, BaseSettings
  File "..../lib/python3.10/site-packages/pydantic/__init__.py", line 206, in __getattr__
    return _getattr_migration(attr_name)
  File "..../lib/python3.10/site-packages/pydantic/_migration.py", line 279, in wrapper
    raise PydanticImportError(
pydantic.errors.PydanticImportError: `BaseSettings` has been moved to the `pydantic-settings` package. See https://docs.pydantic.dev/2.0/migration/#basesettings-has-moved-to-pydantic-settings for more details.
sbrugman commented 1 year ago

Indeed, we should upgrade!

miguelpher commented 1 year ago

Thank you @sbrugman !