search

ing-bank / probatus

Validation (like Recursive Feature Elimination for SHAP) of (multiclass) classifiers & regressors and data used to develop them.
https://ing-bank.github.io/probatus
MIT License
132 stars 40 forks source link

Correct mask dimension #178

Closed gverbock closed 2 years ago

gverbock commented 2 years ago

Pull request based on #176

gverbock commented 2 years ago

@Matgrb @timvink I made a PR on what I believe is a bug in the implementation of the mask. It introduces fluctuations in the shap value between for example train and test.

I believe one could also go further and make the masking optional for algorithm that are not Linear Regressions.

gverbock commented 2 years ago

Yes, this is finished. I will remove the draft status.

gverbock commented 2 years ago

@Matgrb Can I merge, I see you approved so I guess it is ready to go.