Closed markdregan closed 1 year ago
Thanks for the PR. I’ll review it once it’s complete. Please have a look at the current GitHub actions run output. Will rerun it once you pushed new changes.
@ReinierKoops - I seem to have based this PR off some older version of probatus. Just submitted fresh PR. Apologies. I'll delete this PR.
PR addresses #216
Overall objective: Add penalty to features that has high variance in underlying shap values - when computing feature importance. This will (in theory) encourage selection of features that have more coherency across CV folds.
Work tasks:
shap_variance_penalty
parameter toShapRFECV.fit
,compute
&fit_compute
shap_variance_penalty
parameter toEarlyStoppingShapRFECV.fit
,compute
&fit_compute
shap_variance_penalty
toshap_helpers.calculate_shap_importance
shap_variance_penalty
toShapModelInterpreter.fit
,compute
&fit_compute
shap_variance_penalty
featureReviewers: LMK any changes / improvements that can be made.