search

ing-bank / probatus

Validation (like Recursive Feature Elimination for SHAP) of (multiclass) classifiers & regressors and data used to develop them.
https://ing-bank.github.io/probatus
MIT License
132 stars 40 forks source link

Fixing tests for shap==0.42.1 #228

Closed detrin closed 1 year ago

detrin commented 1 year ago

https://github.com/ing-bank/probatus/issues/225

Also fixed one test for numpy>=1.24.0.

Btw, what is the suggested workflow with pre-commit? Add it into virtual env and commit from a command line after I used pre-commit run? Do you use vscode as well?

detrin commented 1 year ago

@ReinierKoops Could you have a look at this PR?

ReinierKoops commented 1 year ago

Lets see how it runs. Please have a look at the file https://github.com/ing-bank/probatus/blob/main/CONTRIBUTING.md

ReinierKoops commented 1 year ago

Thanks again, nice work!

detrin commented 1 year ago

@ReinierKoops I am glad to help :)

I followed the instructions, however I am not sure whether I should use pre-commit within venv or globally. Do yo personally use venv or poetry or something else?

ReinierKoops commented 1 year ago

Personally I use conda separate env to test it