search

ing-bank / probatus

Validation (like Recursive Feature Elimination for SHAP) of (multiclass) classifiers & regressors and data used to develop them.
https://ing-bank.github.io/probatus
MIT License
128 stars 40 forks source link

Fixes the use of eval_metric in case of EarlyStoppingShapRFECV with LightGBM #261

Closed PaulZhutovsky closed 2 months ago

PaulZhutovsky commented 3 months ago

This fixes issue #259 in the exact way described in the issue.

It indeed removes the warning and uses the defined eval_metric in case of LightGBM. I have no idea how to "formally" test that. @ReinierKoops please advice.

ReinierKoops commented 3 months ago

Hi @PaulZhutovsky, thanks for the fix! This https://github.com/microsoft/LightGBM/issues/6035 provides an opportunity for us to fix the automated checks. I'll review the code.

ReinierKoops commented 2 months ago

@PaulZhutovsky ~the runner is fixed. It now seems related to the implementation changes.~

ReinierKoops commented 2 months ago

@PaulZhutovsky thanks for the contribution!