Enforce scalastyle - Githubissues

ing-bank / scruid

Scala + Druid: Scruid. A library that allows you to compose queries in Scala, and parse the result back into typesafe classes.

Apache License 2.0

115 stars 29 forks source link

Enforce scalastyle #102

Closed mmartina closed 4 years ago

mmartina commented 4 years ago

trigger scalastyle sbt plugin as part of compile and test configuration
revised and cleaned up scalastyle config
added/enabled more rules, as specified in: http://www.scalastyle.org/rules-1.0.0.html
fixed scalastyle issues or disabled specific rules on the spot
introduced String helper function toOneLine to work with multiline text
deprecated Dim.=<(value: String)

Fokko commented 4 years ago

Should we remove scalafmt then?

mmartina commented 4 years ago

Should we remove scalafmt then?

I do not think so. Scalafmt and Scalastyle are complementary tools. Yes, in part they control the same aspects and can be contradictory. Therefore, they both need to be carefully fine-tuned.

barend commented 4 years ago

Regarding the sbt-scalafmt, I noticed that the com.lucidchart plugin we're using is on low freq maintenance (i.e. "done"), but there's another plugin of the same name but different groupId that's much more recently maintained.

I chose to stick with the one we're already using to minimize impact. If we're doing a larger overhaul in this area, we might want to update to the newer one.

barend commented 4 years ago

LGTM

anskarl commented 4 years ago

LGTM too