search

ing-bank / scruid

Scala + Druid: Scruid. A library that allows you to compose queries in Scala, and parse the result back into typesafe classes.
Apache License 2.0
115 stars 29 forks source link

Adds support for non-string types in query context parameters #112

Closed anskarl closed 3 years ago

anskarl commented 3 years ago

Adds support for non-string types in query context parameters

  - Adds missing constants to Query Context Parameters
  - Uses implicit value classes along with a circe encoder to support numbers and boolean in context parameters
  - Changes common.runtime.properties to enable query laning, in order to test the integer context parameter 'priority'
  - Updates unit tests
  - Updates documentation
  - docker-compose exposed ports changes to fix CI issues

GH-111

anskarl commented 3 years ago

Before making this PR I've noticed a problem in the CI, I was getting the following error: Screenshot 2021-05-24 at 10 15 43 PM

I was able to resolve it by changing the exposed port numbers in the docker-compose, thus also changed some config settings in the unit tests (see second commit of this PR ef98646).

stswn commented 3 years ago

LGTM. Thanks for the PR!