search

ing-bank / scruid

Scala + Druid: Scruid. A library that allows you to compose queries in Scala, and parse the result back into typesafe classes.
Apache License 2.0
115 stars 29 forks source link

SBT version 1.x.x #20

Closed vkorchik closed 6 years ago

vkorchik commented 6 years ago

Hey guys.

Are there any plans to bump sbt version to 1.x.x? All plugins support sbt 1.x.x, so there should be no problems.

Fokko commented 6 years ago

Hi @vkorchik, currently it isn't on the roadmap, but I don't have anything against upgrading SBT. @krisgeus any thoughts?

krisgeus commented 6 years ago

If indeed all the current plugins support it and the release can be made with sbt 1 I'm perfectly ok with it

vkorchik commented 6 years ago

@Fokko, I don't know if this is a big deal, but this is what I have now. As you can see in the answer, this bug was fixed in 0.13.16 (and scruid has 0.13.15). (To run tests I needed to change project's build.properties to use newer version, in my case 1.1.5)

I saw this error first when upgraded to Ubuntu 18.04. On the other hand everything's ok on MacOS.

Apart from that, I think it is always better to keep up with the newest version of dependencies.

Fokko commented 6 years ago

Yesterday evening I've build your branch on OSX and it worked fine. Not sure what OS the CI is running, but it seems to work at CircleCI as well. Like @krisgeus said, I'm also perfectly fine with upgrading to 1.x.x. And I agree, should keep up with the dependencies.

Cheers, Fokko

Fokko commented 6 years ago

@vkorchik Master is now at SBT 1.1.5.