ing-bank / scruid

Scala + Druid: Scruid. A library that allows you to compose queries in Scala, and parse the result back into typesafe classes.
Apache License 2.0
115 stars 29 forks source link

Incorrect build for 1.2.0 #39

Closed shiawuen closed 5 years ago

shiawuen commented 5 years ago

I am installing the 1.2.0 from https://bintray.com/ing-bank/maven-releases/scruid/1.2.0 but when I look into the source code of the installed package, it doesn't contain the changes you released for 1.2.0, instead it seems to be the earlier version.

Below is my build.sbt


lazy val root = (project in file(".")).
  settings(
    inThisBuild(List(
      organization := "com.example",
      scalaVersion := "2.11.11",
      version      := "0.1.0-SNAPSHOT"
    )),
    name := "scruid-test",
    libraryDependencies ++= Seq(
      "org.scalatest" %% "scalatest" % "3.0.5" % Test,
      "ing.wbaa.druid" %% "scruid" % "1.2.0"
    )
  )

I open the DruidConfig.scala and below are the code install from the package

// omitted license
package ing.wbaa.druid

import com.typesafe.config.ConfigFactory

import scala.concurrent.duration.FiniteDuration
import scala.language.implicitConversions

/*
 * Druid API Config Immutable
 */
object DruidConfig {
  implicit def asFiniteDuration(d: java.time.Duration): FiniteDuration =
    scala.concurrent.duration.Duration.fromNanos(d.toNanos)

  private val config      = ConfigFactory.load()
  private val druidConfig = config.getConfig("druid")

  /** Druid url */
  val host: String                           = druidConfig.getString("host")
  val port: Int                              = druidConfig.getInt("port")
  val secure: Boolean                        = druidConfig.getBoolean("secure")
  val url: String                            = druidConfig.getString("url")
  val datasource: String                     = druidConfig.getString("datasource")
  val responseParsingTimeout: FiniteDuration = druidConfig.getDuration("response-parsing-timeout")
}

Any idea how I could install the latest version of your package?

shiawuen commented 5 years ago

Discovered the issue, the code on your README is not release yet. Will close the issue for now.