search

ing-bank / scruid

Scala + Druid: Scruid. A library that allows you to compose queries in Scala, and parse the result back into typesafe classes.
Apache License 2.0
115 stars 29 forks source link

Fix strict mode in 'bound' filter #62

Closed thelgis closed 5 years ago

thelgis commented 5 years ago

Fixes strict mode of 'bound' filter in Scruid DSL so that it is in agreement with Druid's documentation.

According to Druid's documentation strict comparison in bound filter means using > instead of >= and < instead of <=. This is currently the other way around in Scruid's DSL. The fix makes the behavior consistent with Druid.

Also, fixes a small inconsistency in the DSL. Currently 'greaterThanEquals' is expressed as >=, whereas 'lessThanEquals' is expressed as =<. The fix makes 'lessThanEquals' to be <=.

@anskarl the changes are in the DSL so can you please validate as well?

anskarl commented 5 years ago

@thelgis the fix LGTM

Fokko commented 5 years ago

Thanks @thelgis and @anskarl for the review