Include all Dockerfiles in the project and switch to GitHub Actions and Packages

ing-bank / scruid

Scala + Druid: Scruid. A library that allows you to compose queries in Scala, and parse the result back into typesafe classes.

Apache License 2.0

115 stars 29 forks source link

Include all Dockerfiles in the project and switch to GitHub Actions and Packages #84

Closed anskarl closed 4 years ago

anskarl commented 4 years ago

Docker images

Makefile for building the required docker images
./services.sh start: when images are not available will try to build the images locally
Alpine-based images for Apache druid and chaos-proxy
Openresty, Druid, Zookeeper and Chaos-proxy versions can be customized via arguments in Makefile
Github docker registry
Default Druid version is 0.16.0

Switch to GitHub actions

similar to the current CircleCI workflow:
- workflow is triggered on push or pull request
- .ivy2 directory is cached (hashed base on the checksum of build.sbt)
- coverage report is being archived
adds docker image publishing to github packages:
- credentials are managed by github
- no need to have separate user/space on Docker Hub
use of common .env file for both docker-compose and Makefile. The versions of external services (e.g., Druid) are controlled here
the workflow is portable, since forked repos will automatically publish images on their owner space
simplifications on Makefile (no need for latest tag, automatically load the contents of .env file)

barend commented 4 years ago

Hi @anskarl this is great stuff! I like GitHub actions (I actually have a half-done impl on my laptop, but I never got around to finishing it). I have made time to look into this and your other PR on Friday, together with @bjgbeelen. Sorry about the delayed response.

anskarl commented 4 years ago

@barend thanks for the comments! I will make the version updates and remove the .circleci directory, possibly today or in the weekend.

anskarl commented 4 years ago

I've made the required changes (versions and removal of .circleci directory).

I've also made some additional changes:

I found that I forgot to set the REPOSITORY_OWNER environment variable in the docker-compose.yaml file. Therefore, I've updated the file and did some minor adjustments to services.sh and Makefile for this environment variable.
I've updated the Dockerfiles to use set -ex at the beginning of each RUN expression
The build image of clusterf-chaos-proxy now uses maven:3.6.3-jdk-8-slim which is Debian-based, therefore the installation of required tools (git and openssh client) have been also adjusted.

With the upgrade of all image/tool versions and Dockerfiles, in practice we have an additional verification that the entire process of building, testing and publishing of docker images is automated and produces the expected results :)

barend commented 4 years ago

Looks good to me, thanks for updating.

The Circle-CI fails because the configuration was removed, which is precisely the aim of this PR.