Adds support for Select, Scan and Search queries

ing-bank / scruid

Scala + Druid: Scruid. A library that allows you to compose queries in Scala, and parse the result back into typesafe classes.

Apache License 2.0

115 stars 29 forks source link

Adds support for Select, Scan and Search queries #85

Closed anskarl closed 4 years ago

anskarl commented 4 years ago

Changes interval query and response API in order to support the three new queries
Legacy mode for Scan queries is configurable from application.conf
Updates documentation and examples for new queries
Updates unit tests to examine new queries
All Druid Queries have toDebugString utility function, in order to get the corresponding native JSON representation of the query as a string (useful for debugging purposes)

GH-83

bjgbeelen commented 4 years ago

Thanks @anskari. I’ll have a look at them this friday!

anskarl commented 4 years ago

Looks good. Nice improvements indeed!

One minor thing I noticed is the naming DruidResponseScanImpl e.g. I would probably have chosen to use DruidScanResponse. You do use DruidScanResult(s), so just to make it more consistent.

I agree, I will change the name to DruidScanResponse.

barend commented 4 years ago

Thank you for updating the PR