Release v2.4.0 - Githubissues

ing-bank / scruid

Scala + Druid: Scruid. A library that allows you to compose queries in Scala, and parse the result back into typesafe classes.

Apache License 2.0

115 stars 29 forks source link

Release v2.4.0 #97

Closed anskarl closed 4 years ago

anskarl commented 4 years ago

Since v2.3.0, an outline of the new features and changes is given below:

Include all Dockerfiles in the project and switch to GitHub Actions and Packages (GH-84)
Scan and Search queries (GH-83, GH-85, GH-89 and GH-92)
Additional Float and String aggregators (GH-86)
Support for Druid SQL (GH-90 and GH-91)
Use requestInterceptor in health checks (GH-93 and GH-94)
Use com.typesafe.scala-logging instead of using slf4j directly (GH-95)
Expand "tests" section in README file (GH-96)

Is it possible to proceed with a new release of Scruid library (v2.4.0)?

barend commented 4 years ago

If it were released as-is I would be okay with that, but there are a couple of things I would like to fix before the release:

I can see in the build output that I've somehow managed to log the stack trace with health check failures, despite my intention not to. Probably a difference between raw SLF4J and Typesafe-Logging that I overlooked. I think the logging is too noisy there.
I am a little bit bothered by the "upstream failed / abrupt termination" warnings in the unit test suite. If we can do a clean stop in the tearDown handler, there won't be that "boy who cried wolf effect" if we ever introduce a real warning
We're also a bit behind on some of the dependency versions, but I haven't checked yet whether any of those are blocked because the upstream dropped Scala 2.11 support

barend commented 4 years ago

I'll create a PR with some pre release housekeeping

barend commented 4 years ago

Pull request ready for review. Resolving those Akka shutdown warnings turns out not to be really feasibly. There are tons of issues mentioning them, which are unresolved since 2015 or so. That suggests it's a tough one.

anskarl commented 4 years ago

Indeed it's a an old and unresolved issue regarding the Akka shutdown error message. The error message in Scruid is fired from the logging of cachedHostConnectionPool Flow. When, for example, comment out the .log("scruid-load-balancer", _ => s"Sending query to ${queryHost.host}:${queryHost.port}") part in DruidAdvancedHttpClient.scala then the error message is not exposed.

I think it is safe leave it unchanged. Perhaps in a future release of Akka it may be resolved.

mmartina commented 4 years ago

Hi Anastasios, we expect to complete release 2.4.0 before the end of this week. best regards, Marcus Martina

mmartina commented 4 years ago

released :)