ing-bank / skorecard

scikit-learn compatible tools for building credit risk acceptance models
https://ing-bank.github.io/skorecard/
MIT License
84 stars 23 forks source link

Modified bucket_table() to compute WoE consistent with category_encoder #88

Closed dlaprins closed 1 year ago

dlaprins commented 1 year ago

87

Hard-coded WoE calculation in bucket_table to be consistent with the category_encoder (v2.5.1) implementation of WoE.

A direct call on the WOEEncoder object might be preferable, but seems inconvenient given the currrent code setup.

anilkumarpanda commented 1 year ago

Hey @dlaprins thanks for the PR. Can you write an unit test to test you change ?