search

ing-bank / threshold-signatures

Threshold Signature Scheme for ECDSA
MIT License
201 stars 41 forks source link

Phase1 doesn't take into account list of signers #34

Closed survived closed 1 year ago

survived commented 2 years ago

At phase1, signer tries to send p2p messages to every party holding a share regardless whether this party appear in list of signers. In other words, at phase1 party sends n messages, but should send t+1 messages.

Here's the code that causes this behaviour:

  1. Phase1::start generates list of messages. Messages are sent to every party listed in the map in phase1.mta_a
  2. The map is constructed in Phase1::new, note that every party from keygen is included, regardless whether this party appears in signers list

Suggested solution: filter out parties that are not listed in signers list from the map in Phase1::start

igmar commented 1 year ago

ING has no intention of resolving this, nor on maintaining this further, and hence, this repo will be archived. Its usage is no longer recommended, see the updated README.