@acoulton, can you have a look over this, something doesn't feel right but it's perhaps just how its got to be tested without actually setting cookies.
I've had to add $samesite as an argument to our internal set_cookie() method to assert against it in the tests. We only actually add the option 'samesite' to \setcookie() if it's not NULL which should all follow the current behaviour
The value of the samesite element should be either None, Lax or Strict. If any of the allowed options are not given, their default values are the same as the default values of the explicit parameters. If the samesite element is omitted, no SameSite cookie attribute is set. from https://www.php.net/manual/en/function.setcookie.php
@acoulton, can you have a look over this, something doesn't feel right but it's perhaps just how its got to be tested without actually setting cookies.
I've had to add $samesite as an argument to our internal set_cookie() method to assert against it in the tests. We only actually add the option 'samesite' to \setcookie() if it's not NULL which should all follow the current behaviour
The value of the samesite element should be either None, Lax or Strict. If any of the allowed options are not given, their default values are the same as the default values of the explicit parameters. If the samesite element is omitted, no SameSite cookie attribute is set.from https://www.php.net/manual/en/function.setcookie.php