set and check monitoring._read_process_finished a to improve stabilit… - Githubissues

ingeniamc / ingeniamotion

Motion library for Ingenia servo drives

Other

6 stars 0 forks source link

set and check monitoring._read_process_finished a to improve stabilit… #244

Closed polfeliu closed 2 weeks ago

polfeliu commented 2 weeks ago

[Doc] Investigate and found a possible pitfall in the design of the test

Intended behaviour:

Test starts thread
Thread calls read_monitoring_data
read_monitoring_data (in thread) sets flag _read_process_finished to False
Test calls stop_reading_data
stop_reading_data sets flag _read_process_finished to True
read_monitoring_data stops

Spurious behaviour

Test starts thread
Test calls stop_reading_data
stop_reading_data sets flag _read_process_finished to True
Thread calls read_monitoring_data
read_monitoring_data (in thread) sets flag _read_process_finished to False
read_monitoring_data does not stop because _read_process_finished is False

Now behaviour:

Set _read_process_finished to True
Test starts thread
Thread calls read_monitoring_data
Wait main thread for _read_process_finished to be False
read_monitoring_data (in thread) sets flag _read_process_finished to False
Wait ends
Test calls stop_reading_data
stop_reading_data sets flag _read_process_finished to True
read_monitoring_data stops

[Test] Difficult to actually test because I've had difficulties reproducing the error. At least the jenkins build passes