search

ingeniasoftware / luthier-ci

Improved routing, middleware support, authentication tools and more for CodeIgniter 3 framework
https://luthier.ingenia.me/ci/en/
MIT License
151 stars 39 forks source link

PHP 5.6 compatibility #17

Closed hostekevin closed 6 years ago

hostekevin commented 6 years ago

Hello,

I found an error when deploying on a 5.6 php version :

Fatal error: Cannot use Luthier\RouteBuilder as Route because the name is already in use in vendor\luthier\luthier\src\Debug.php on line 15

Removing this line allow me to use it with php 5.6

use Luthier\RouteBuilder as Route;

thanks

hostekevin commented 6 years ago

I see that is already solved in github project ?

andersonsalas commented 6 years ago

Hi! I confirmed the bug (PHP 5.6/W8.1 x64) but when remove that line I got the following fatal error:

Fatal error: Default value for parameters with a class type hint can only be NULL in C:\Apache\htdocs\luthier-ci-tester\application\vendor\symfony\var-dumper\Dumper\CliDumper.php on line 61

Let me make a few tests before pushing the changes in the repo, just for being sure :+1:

andersonsalas commented 6 years ago

Versión 1.0.0 released

hostekevin commented 6 years ago

Thank you :)