search

ingenico-group / foreman_expire_hosts

Deprecated, see https://github.com/theforeman/foreman_expire_hosts theforeman plugin for limiting host lifetime
https://github.com/theforeman/foreman
GNU General Public License v3.0
5 stars 3 forks source link

Refactoring #1

Closed ohadlevy closed 9 years ago

ohadlevy commented 9 years ago

Hi,

I've started reviewing the plugin, and starting refactoring, this is an initial set of suggestions

thanks!

iakovgan commented 9 years ago

Awsome thanks! We will review this asap.

ohadlevy commented 9 years ago

@iakovgan @nagarjuna I would suggest to review each commit, its probably easier to digest.. if its too much, i don't mind breaking down to multiple pull requests, but would need to make sure at least the initial one is merged as it blocks the rest.

nagarjuna commented 9 years ago

@ohadlevy So you are suggesting to make datepicker gem as dependent and need to bundle as separate RPM(datepicker is one RPM and foreman_expire_hosts is another RPM) ?

ohadlevy commented 9 years ago

@nagarjuna exactly

nagarjuna commented 9 years ago

@ohadlevy OK will merge your changes and build gem, later will bundle RPM packages(both bootstrap-datepicker and foreman_expire_hosts). Thanks for your suggestions :)