search

ingenieux / awseb-deployment-plugin

Jenkins Plugin for AWS Elastic Beanstalk
Apache License 2.0
29 stars 53 forks source link

Too-strict checking of environment name length #32

Closed cjosw closed 8 years ago

cjosw commented 8 years ago

We've just upgraded to version 0.3.5 of the plugin.

We have an Elastic Beanstalk application with an environment name which is 25 characters long. It looks like this: "abc-cfn-test2-myapp123env"

However, the new plugin won't accept this in its configuration; it complains with a warning: "Doesn't look like an environment name. Must be from 4 to 23 characters in length. The name can contain only letters, numbers, and hyphens. It cannot start or end with a hyphen"

Where has this limit of 23 come from? The code in AWSEBDeploymentBuilder.doCheckEnvironmentName(...) (line 262) doesn't state where this number was derived.

[We were happily using the same name in an older version of this plugin, and in the maven plugin]

Note that this message appears as a warning within the Jenkins configuration page; it doesn't seem to actually prevent deployment.

aldrinleal commented 8 years ago

http://docs.aws.amazon.com/cli/latest/reference/elasticbeanstalk/create-environment.html

^F, "--environment-name"

cjosw commented 8 years ago

Ah, OK. We have created our environment using CloudFormation. It doesn't appear to have this limit, and as far as I can tell, EleasticBeanstalk is working fine with this long name. But I now find that when creating a new environment using the AWS console, it does apply the same 4 to 23 characters limit.

I'll fix our CloudFormation templates to use shorter names.