search

inglettronald / DulkirMod-Fabric

Quality of Life Skyblock Mod for Modern Versions of Minecraft
Mozilla Public License 2.0
14 stars 8 forks source link

Sliders not working properly on Lunar Client #15

Open GABRlEL opened 5 days ago

GABRlEL commented 5 days ago

Hey there, sorry to bother you with things that mix private work and business work. I'm trying to make your mod work with Lunar Client for MCC Island 1.21 - and the sliders for the animationPresets don't work. They don't set any value and are draggable over the entire screen. image (please don't mind my ultrawide screen)

I tried to manually edit config but I can't get it to work, it won't load my config and just resets on game load. Editing scale works though, presumably because it's a text field and not a slider?

GABRlEL commented 4 days ago

Please don't mind my hacky code, but changing the IntSlider to IntField does work, I have tried with my fork: https://github.com/GABRlEL/DulkirMod-Fabric-LunarSliderFix/blob/master/src/main/kotlin/com/dulkirfabric/config/DulkirConfig.kt image

EDIT: I only fixed it for animations since this was the only thing relevant for me. I expect the fix to work everywhere though

GABRlEL commented 2 days ago

short update, my fork (not sure if it's related to my fork or lunar) fails to load the config so you have to set the settings every time again

inglettronald commented 1 day ago

Sorry, I've been out of the house for the past few days, I'll try to look at this when I'm porting the mod to 1.21.3/4 soon(tm)!

GABRlEL commented 1 day ago

Sorry, I've been out of the house for the past few days, I'll try to look at this when I'm porting the mod to 1.21.3/4 soon(tm)!

No worries! Atleast the MCC Island Modpack is not past 1.21 yet anyways