search

ingmar-k / Pogoplug_V3_Emdebian_Debian

Scripts to create a bootable Emdebian/Debian USB-Stick for the Pogoplug V3 devices.
12 stars 6 forks source link

Script starts directly without prior warning #2

Closed kuleszdl closed 11 years ago

kuleszdl commented 11 years ago

When executing the script, it immediately starts downloading stuff and thus making not easily undoable changes to the system. It would be cool, if the script would display a warning and ask for confirmation before proceeding.

ingmar-k commented 11 years ago

What the script does is an "apt-get update" first, in order to be able to download all the packages that are REQUIRED for the function of the script. So, a warning at that point doesn't really make sense to me. It is simply necessary to download those packages, if you want to run the script. So I don't really see the need to "fix" something in that case.

What I could do is to make it even more clear in the README that a working internet connection is needed right away when starting the script. (Edit: This is done.)

I mean I could halt the script with an INFO message stating the need for an internet connection NOW, giving the user time to establish aforementioned connection, before continueing. It just seems a bit 'over the top'.

kuleszdl commented 11 years ago

Actually I looked into the script before and saw various targets like "--install", thus I was expecting to get a usage message first instead of just starting...and it does not just do "apt-get update" but it continues with installing stuff via "apt-get install"

ingmar-k commented 11 years ago

Of course it installs stuff. The required packages are listed in the "general_settings.sh" as the two "aptprerequisites*" variables.

The point is that the script only installs those packages that are missing. It goes like that:

Without installing those packages you simply cannot run the rootfs creation.

kuleszdl commented 11 years ago

Yes I agree, of course the script has to act. :-) I was just expecting some sort of "I will do this and that, are you ready? Click enter to proceed"-message.

ingmar-k commented 11 years ago

Yeah well, it's more of a "don't ask, just do" kind of script. And in this case this was actually by design. You set what you want to have as output in the main settings file and off it goes.

The basis for this very script is found in the Gnublin Project of the Hochschule Augsburg, for which I wrote the first script for a automated Debian rootfs creation. The focus was to create a script run by the board manufacturer (Embedded Projects GmbH) with the least possible user interaction, in order to get a working Debian Image.

And as I wanted something quick for the Pogoplug, that's where it came from and that's why it works like it does. ;-)

ingmar-k commented 11 years ago

Oh and btw, the "--install" Parameter might be a bit misleading. It is for transfering a completed rootfs-archive to a USB pendrive, without running the complete build process again. So if you have a ready to use archive, but need a new USB drive that's what this option is for. If you can't find documentation for it in the README, have a look at m other projects. They are quite similar, so there could be some info you need. I might have to add that to the README some time soon. Good that you mentioned it.