search

ingmar-k / Pogoplug_V3_Emdebian_Debian

Scripts to create a bootable Emdebian/Debian USB-Stick for the Pogoplug V3 devices.
12 stars 6 forks source link

No warning on not-verifiable packages #3

Closed kuleszdl closed 11 years ago

kuleszdl commented 11 years ago

In case packages cannot be authenticated, the script does not interrupt but silently continues without notifying the user. See also:

https://gist.github.com/kuleszdl/5382297

ingmar-k commented 11 years ago

The whole idea behind the script was creating something that runs without any "unnecessary" user interaction.

Like this: Make the changes in the 'general_settings.sh' file --> run the script --> Take the USB stick and run it.

Considering that scenario this potential problem was accepted as a necessary compromise, if you will. Furthermore, errors happening inside the qemu environment are not easily handled on the development system the script runs on. As I said, I will look into it, but I can't guarantee that I'll get around to fix it.

kuleszdl commented 11 years ago

I agree. In general, the script automates a lot of stuff and is probably acting very optimistic in this regard.

Maybe a possible way to avoid certain problems could be to do some sanity checks upfront like:

Of course, such checks can't guarantee that these conditions will still hold true when the script starts executing, but at least some errors could be caught upfront without introducing tons of complexity in the script's workflow. Since it is meant to automate stuff ,the optimistic approach seems valid.

ingmar-k commented 11 years ago

Actually the pendrive creation isn't fully automated and still requires user interaction, because full automation would be way too dangerous. You could easily wipe a wrong disk this way. Your points about the keys and network setup are valid. It's just that it usually works, if you set it up correctly. The scenarios that you are concerned about imply that there is either a wrong setting or an unforseen error. I agree that those should be considered and possibly handled. The reality is just that this is a small project written as fast as possible to make my life easier.

So, to get this 100% userfriendly and error free probably won't happen unless I find a LOT of free time.

kuleszdl commented 11 years ago

Yeah, it doesn't also make sense to get it 100% error free since this would increase complexity a lot, as there are dozens of various error conditions in which you could run into. It would be cool if the very basic errors (which probably happen most of the time) could be handled a basic sanity check first.

ingmar-k commented 11 years ago

As I said, I'll try to fix what I can. I just can't guarantee it. ;-)

ingmar-k commented 11 years ago

GPG problems should be fixed in new script commit. I did a more or less complete rework of the previous version. You can give it a go and let me know if you still encounter the same problems.

ingmar-k commented 11 years ago

In the end it turned out to be kind of a debootstrap problem, it seems. Even though the archive keys were installed, they were not found by debootstrap. Probably because of the use of a chroot environment. So, what seems to have solved that problem is a combination of passing the keys via call parameter, directly to debootstrap, plus updating the chroot's archive keys, too. Now, with the latest version of the scripts, this finally seems to be fixed. Knock on wood. ;-)

kuleszdl commented 11 years ago

Well, that's great news. :+1: