search

ingolemo / firefox-dynamic-zoom

Firefox plugin to emulate viewing webpages in a fixed pixel wide window by dynamically adjusting the page zoom.
GNU General Public License v3.0
6 stars 1 forks source link

[Feature Request] per URL override settings #1

Open Lockszmith-GH opened 6 years ago

Lockszmith-GH commented 6 years ago

Awesome Zoom add-on. Probably the best thought off zoom solution I've encountered. So - first - Thank You!

My request: have the ability to toggle the current page in/out of an exclusion list for the auto-zoom.

The first URL I'll add to this list would be about:addons.

Thanks in advance.

ingolemo commented 6 years ago

Why specifically the about:addons page? It should look fine for any zoom width other than 800 (which is also horribly small for just about every other webpage). This is a feature that would be nice to have and I might add it when I find time, but if there's something broken in about:addons then I'd put a rush on fixing it.

Lockszmith-GH commented 6 years ago

The actual Add On manager looks ok, but some options windows enter a rendering loop for some reason.

This happened to me with "Lyrics Here by Rob W" and "Temporary Containers". Besides, such a blacklist would allow to custom zoom for certain sites, and yet continue using dynamic zoom everywhere else.

ingolemo commented 6 years ago

I can't seem to reproduce the issue on my end with either of those addons. Could you provide more detailed instructions, or a screenshot or something?

darkj2k commented 6 years ago

A blacklist function will be great. Also, is it normal that webextension element was effected by Dynamic Zoom? For example, the popup window size of Swift Selection Search is changed by Dynamic Zoom level.

ingolemo commented 6 years ago

That SSS element is not really a popup window in a technical sense. It's part of the webpage and can't easily be zoomed separately from it. I don't think it needs to be anyway, as the zoomed version looks fine to me.

My main issue with the blacklist is that I don't currently understand the use-case for it. Right now, dynamic zoom is an intentionally simple addon. Introducing a blacklist wouldn't be hard per-say, but it would make everything more complicated. I'd have to add a preferences window to let you manage the blacklist and I'd have to come up with rules about how you specify sites (is www.example.com caught by a blacklist for example.com, for example). I'd have to save those preferences and update the different parts of the UI to keep them in sync. Like I said; this isn't hard, but it would increase the amount of code in the project ten-fold and I'm not sure that's really worth it. I'd rather just fix issues so that all webpages zoom correctly to begin with and no-one needs any manual control.

All that said, I'm not opposed to adding a blacklist. But I would want to know what problems you guys are actually having and how those problems would be best solved specifically by adding a blacklist. Convince me.

millionart commented 5 years ago

When the zoom ratio exceeds 100%, the simple image address cannot be displayed completely (https://***.png etc.)

ingolemo commented 5 years ago

I'm not really sure what you're referring to. Could you provide more details?

millionart commented 5 years ago

My zoom ratio is 200%, everything is perfect, but all open image links are up to 200% and therefore cannot be fully displayed. I want to increase the address exclusion feature that supports regular expressions.

crssi commented 5 years ago

@Lockszmith

The first URL I'll add to this list would be about:addons.

about:addons is a special mozilla page (there are other mozilla pages like that too), where web extensions does not work.