search

ingonyama-zk / icicle

a GPU Library for Zero-Knowledge Acceleration
MIT License
303 stars 88 forks source link

precompute bug fix #529

Closed HadarIngonyama closed 2 months ago

HadarIngonyama commented 2 months ago

This PR fixes 2 things:

  1. Removes the assertion regarding the precompute factor needing to be a power of 2. There is no such requirement and it works just fine for other values too.
  2. Fixes the average bucket size for the large buckets threshold - it depends on the precompute factor.
jeremyfelder commented 2 months ago

Merging with the failed spell check since it will be fixed in https://github.com/ingonyama-zk/icicle/pull/528