ingonyama-zk / icicle

a GPU Library for Zero-Knowledge Acceleration
MIT License
303 stars 88 forks source link

Fix/vlad/affine to proj #552

Closed vladfdp closed 3 weeks ago

vladfdp commented 4 weeks ago

Describe the changes

This PR fixes some of the affine -> projective functions by adding a condition If the point in affine form is zero then return the projective zero

Linked Issues

Resolves #

jeremyfelder commented 3 weeks ago

I don't think it is too much work to extern the from_affine function in cpp and use that directly in Rust and Go so we truly have a single implementation for this logic

If we choose not to do this for the hotfix, then lets add a test case in both Rust and Go: