Add montgomery to vec_ops and example of that

ingonyama-zk / icicle

A hardware acceleration library for compute intensive cryptography :ice_cube:

https://dev.ingonyama.com/icicle/overview

MIT License

329 stars 97 forks source link

Add montgomery to vec_ops and example of that #566

Open danny-shterman opened 2 months ago

danny-shterman commented 2 months ago

Describe the changes

This PR...

Linked Issues

Resolves #

ChickenLover commented 1 month ago

@danny-shterman I agree with Yuval here. Benches, tests and examples are three different things and they shouldn't be mixed. There is very few value in the 800 line example of doing vector multiplication. If it's urgent, feel free to merge. Otherwise - I would suggest to take some more time to split it into bench, test and a short example. If you have multiple features to showcase in an example - you can just copy paste and make several files inside one folder