search

ingowald / optix7course

Apache License 2.0
452 stars 80 forks source link

reverse cube face #46

Closed AlexeySmolenchuk closed 8 months ago

AlexeySmolenchuk commented 8 months ago

One of the triangles is reversed in the default cube: image

I know. Not a big deal. Just for consistency.

Sorry for the noise with stripped whitespaces.

ingowald commented 8 months ago

Wow! After almost five years, four-hundred stars on github (and probably thousands of people that downloaded and ran this code!?) nobody has found that one yet. And I've since copied and re-used that particular cube setup code into many other repos, where nobody has found it, yet, either ..... amazed, i tell you :-)

Nice catch; also all good on the whitespaces - frankly i don't understand that git cannot figure out that for a C/C++/CUDA file that shouldn't matter, anyway... and quite a few of those whitespaces shouldn't have been there in the first place.

AlexeySmolenchuk commented 8 months ago

Nobody noticed because of fabs(dot(...)). I was just more curious than expected :)