search

ingowalther / image-minify-api

Image Minify API
http://ingowalther.github.io/image-minify-api/
26 stars 3 forks source link

Separating source from web #12

Open AleksanderKoko opened 7 years ago

AleksanderKoko commented 7 years ago

Hi there. Really nice package. I had some ideas on this one.

What I think we can change is to separate the web layer from the source. We can do a second repository with lumen/silex or something similar that is fast and can do the queries, support multiple databases etc. This would keep the core cleaner and SQL free.

This project in my opinion can be a perfect usecase for a microservice architecture. I also see that you have some experience with Docker also. I would love to also contribute on this with a docker configuration and test it on a production environment.

I can do the Docker thing right away and also the lumen part. What do you think?

ingowalther commented 7 years ago

Hello @AleksanderKoko,

thanks for sharing your ideas. I dont like the microservice approach for this project, I think it will make the project much more complex to setup.

But I would love a Docker container with all libs and the application installed in it.

Greetings Ingo

AleksanderKoko commented 7 years ago

Hello @ingowalther . Doing the Docker container today. Will ping you when done.

ingowalther commented 7 years ago

Great! Thank you!

AleksanderKoko commented 7 years ago

Hi @ingowalther. Haven't forgot about this. Dockerfile build but have problems connecting it with the MySQL image. Also included a small Docker compose file so someone can have the project up and running with git clone && docker-compose up -d . As soon as this is done will ping you. Need a bit help on how to structure the documentation.

PS: Happy new year :D