search

ingrammicro / puzzle-publisher

A Sketch plugin that exports Sketch artboards into clickable HTML file and publishes it on an external site.
GNU General Public License v3.0
174 stars 19 forks source link

Not working on Sketch 52.2 #1

Closed Nuneshere closed 5 years ago

Nuneshere commented 5 years ago

Hey guys, just found out this project and i'm excited to test it, for now it's not working on the 52.2 sketch version, what the sketch version that you guys tried on ? in my sketch it's stuck on the "export to html" page with the "please wait..." label fixed

MaxBazarov commented 5 years ago

Hello, I afraid that your Sketch is too old.

Anyway, please check what are the last line in ~/Library/Logs/com.bohemiancoding.sketch3/Plugin\ Log.log

On 23 Aug 2019, at 20:59, Mateusnunes notifications@github.com<mailto:notifications@github.com> wrote:

Hey guys, just found out this project and i'm excited to test it, for now it's not working on the 52.2 sketch version, what the sketch version that you guys tried on ? in my sketch it's stuck on the "export to html" page with the "please wait..." label fixed

MaxBazarov commented 5 years ago

Also you can try old version —Exporter.sketchplugin.3.1.0.ziphttps://github.com/MaxBazarov/exporter/blob/master/achives/Exporter.sketchplugin.3.1.0.zip It was compatible with Sketch 52.2

On 23 Aug 2019, at 22:54, Max Bazarov maxim.bazarov@ingrammicro.com<mailto:maxim.bazarov@ingrammicro.com> wrote:

Hello, I afraid that your Sketch is too old.

Anyway, please check what are the last line in ~/Library/Logs/com.bohemiancoding.sketch3/Plugin\ Log.log

On 23 Aug 2019, at 20:59, Mateusnunes notifications@github.com<mailto:notifications@github.com> wrote:

Hey guys, just found out this project and i'm excited to test it, for now it's not working on the 52.2 sketch version, what the sketch version that you guys tried on ? in my sketch it's stuck on the "export to html" page with the "please wait..." label fixed

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ingrammicro/puzzle-publisher/issues/1?email_source=notifications&email_token=AEMQVAWLZI5SWTANPFJFUELQGAQQPA5CNFSM4IPB77MKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HHDD4GA, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEMQVAT6ZGGZF26WHUM7W7TQGAQQPANCNFSM4IPB77MA.

If you do not wish to receive promotional materials from Ingram Micro via e-mail, please go to http://www.ingrammicro.com/emailmgmt or reply to this message and type unsubscribe in the subject.

Ingram Micro Inc. Corporate Headquarters, 3351 Michelson Drive, Suite 100, Irvine, CA 92612

This email may contain material that is confidential, and proprietary to Ingram Micro, for the sole use of the intended recipient. Any review, reliance or distribution by others or forwarding without express permission is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. [Ingram_2818e5de]

Nuneshere commented 5 years ago

i will check it out and let you know the results :)

yasserlotfy commented 5 years ago

After updating from 7.2.4 the plugin is not working anymore, tried v10.0.0 and v10.0.1 and no luck at all.

here is my plugin.log file:

[Material] Starting Material@1.12.251294740

/Users/yasser/Desktop/Unicom/Notary/Prototypes/Notary Web-App v2.3/images/previews/
exportArtboards: running...
ReferenceError: Can't find variable: index
    at getArtboardGroups (/Users/yasser/Library/Application Support/com.bohemiancoding.sketch3/Plugins/PuzzlePublisher.sketchplugin/Contents/Sketch/menu-export-html-adv.js:2795:120)
    at exportArtboards (/Users/yasser/Library/Application Support/com.bohemiancoding.sketch3/Plugins/PuzzlePublisher.sketchplugin/Contents/Sketch/menu-export-html-adv.js:2976:49)
    at /Users/yasser/Library/Application Support/com.bohemiancoding.sketch3/Plugins/PuzzlePublisher.sketchplugin/Contents/Sketch/menu-export-html-adv.js:3149:54

I hope you could fix the issue.

MaxBazarov commented 5 years ago

Thanks for feedback! Ok, fixed in latest 10.0.2 update. Please verify.

On 1 Sep 2019, at 10:13, yasserlotfy notifications@github.com wrote:

After updating from 7.2.4 the plugin is not working anymore, tried v10.0.0 and v10.0.1 and no luck at all.

here is my plugin.log file: `[Material] Starting Material@1.12.251294740

/Users/yasser/Desktop/Unicom/Notary/Prototypes/Notary Web-App v2.3/images/previews/ exportArtboards: running... ReferenceError: Can't find variable: index at getArtboardGroups (/Users/yasser/Library/Application Support/com.bohemiancoding.sketch3/Plugins/PuzzlePublisher.sketchplugin/Contents/Sketch/menu-export-html-adv.js:2795:120) at exportArtboards (/Users/yasser/Library/Application Support/com.bohemiancoding.sketch3/Plugins/PuzzlePublisher.sketchplugin/Contents/Sketch/menu-export-html-adv.js:2976:49) at /Users/yasser/Library/Application Support/com.bohemiancoding.sketch3/Plugins/PuzzlePublisher.sketchplugin/Contents/Sketch/menu-export-html-adv.js:3149:54`

I hope you could fix the issue.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ingrammicro/puzzle-publisher/issues/1?email_source=notifications&email_token=AEMQVAWVJBUEWUHFMISJ7Q3QHNTRZA5CNFSM4IPB77MKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5T4EUA#issuecomment-526893648, or mute the thread https://github.com/notifications/unsubscribe-auth/AEMQVAW5VSNST4N4IT3LMYTQHNTRZANCNFSM4IPB77MA.

yasserlotfy commented 5 years ago

Thanks for feedback! Ok, fixed in latest 10.0.2 update. Please verify. …

Tested & works on Sketch v57.1 Thanks for the fix.