search

ingrammicro / puzzle-publisher

A Sketch plugin that exports Sketch artboards into clickable HTML file and publishes it on an external site.
GNU General Public License v3.0
174 stars 19 forks source link

Puzzle Publish - Show style source not working #11

Closed josh-tt closed 4 years ago

josh-tt commented 4 years ago

Thanks Max! These plugins (pt and pp) are both very useful.

Unfortunately, I just checked the 'Style Source' and it seems to always say 'document', even though I know for sure the style references another library. For example, you can try the Carbon Design theme from IBM (sketch://add-library/cloud/JaVzz). The 'tags' here are using styles from another library, yet they still say 'document'.

Sketch image: https://snipboard.io/li1PH3.jpg

Puzzle Publisher: https://snipboard.io/tiWBvV.jpg

Perhaps this is related to why I can't get the Element selector drop down working either (it only works on autoselect).

Thanks

MaxBazarov commented 4 years ago

Shame on me! Maybe it works only with libraries which were processed by Puzzle Tokens with enabled “Generate symbols & styles file”. I will check it today.

On 28 Nov 2019, at 20:05, josh-tt notifications@github.com<mailto:notifications@github.com> wrote:

Thanks Max! These plugins (pt and pp) are both very useful.

Unfortunately, I just checked the 'Style Source' and it seems to always say 'document', even though I know for sure the style references another library. For example, you can try the Carbon Design theme from IBM (sketch://add-library/cloud/JaVzz). The 'tags' here are using styles from another library, yet they still say 'document'.

Sketch image: https://snipboard.io/li1PH3.jpg

Puzzle Publisher: https://snipboard.io/tiWBvV.jpg

Perhaps this is related to why I can't get the Element selector drop down working either (it only works on autoselect).

Thanks

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ingrammicro/puzzle-publisher/issues/11?email_source=notifications&email_token=AEMQVAU3QPXBY5MOWVXK66DQV727JA5CNFSM4JSXBUGKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H4XNMJA, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEMQVATFW77LG3SPMHOZGQTQV727JANCNFSM4JSXBUGA.

If you do not wish to receive promotional materials from Ingram Micro via e-mail, please go to http://www.ingrammicro.com/emailmgmt or reply to this message and type unsubscribe in the subject.

Ingram Micro Inc. Corporate Headquarters, 3351 Michelson Drive, Suite 100, Irvine, CA 92612

This email may contain material that is confidential, and proprietary to Ingram Micro, for the sole use of the intended recipient. Any review, reliance or distribution by others or forwarding without express permission is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. [Ingram_2818e5de]

josh-tt commented 4 years ago

Ah. No worries. :) The test was done using the carbon theme which I didn’t use puzzle tokens with. So the theme and the referenced themes all never went through puzzle tokens.

Sent from my iPhone

On Nov 29, 2019, at 2:15 AM, Maxim Bazarov notifications@github.com wrote:

Shame on me! Maybe it works only with libraries which were processed by Puzzle Tokens with enabled “Generate symbols & styles file”. I will check it today.

On 28 Nov 2019, at 20:05, josh-tt notifications@github.com<mailto:notifications@github.com> wrote:

Thanks Max! These plugins (pt and pp) are both very useful.

Unfortunately, I just checked the 'Style Source' and it seems to always say 'document', even though I know for sure the style references another library. For example, you can try the Carbon Design theme from IBM (sketch://add-library/cloud/JaVzz). The 'tags' here are using styles from another library, yet they still say 'document'.

Sketch image: https://snipboard.io/li1PH3.jpg

Puzzle Publisher: https://snipboard.io/tiWBvV.jpg

Perhaps this is related to why I can't get the Element selector drop down working either (it only works on autoselect).

Thanks

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ingrammicro/puzzle-publisher/issues/11?email_source=notifications&email_token=AEMQVAU3QPXBY5MOWVXK66DQV727JA5CNFSM4JSXBUGKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H4XNMJA, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEMQVATFW77LG3SPMHOZGQTQV727JANCNFSM4JSXBUGA.

If you do not wish to receive promotional materials from Ingram Micro via e-mail, please go to http://www.ingrammicro.com/emailmgmt or reply to this message and type unsubscribe in the subject.

Ingram Micro Inc. Corporate Headquarters, 3351 Michelson Drive, Suite 100, Irvine, CA 92612

This email may contain material that is confidential, and proprietary to Ingram Micro, for the sole use of the intended recipient. Any review, reliance or distribution by others or forwarding without express permission is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. [Ingram_2818e5de] — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

MaxBazarov commented 4 years ago

Actually a PT assistance is required only if you use LESS and want to send information about applied tokens to Element Inspector. I need to rewrite PP code to don’t be depended of PT in all other cases.

On 29 Nov 2019, at 06:07, josh-tt notifications@github.com wrote:

Ah. No worries. :) The test was done using the carbon theme which I didn’t use puzzle tokens with. So the theme and the referenced themes all never went through puzzle tokens.

Sent from my iPhone

On Nov 29, 2019, at 2:15 AM, Maxim Bazarov <notifications@github.com mailto:notifications@github.com> wrote:

Shame on me! Maybe it works only with libraries which were processed by Puzzle Tokens with enabled “Generate symbols & styles file”. I will check it today.

On 28 Nov 2019, at 20:05, josh-tt <notifications@github.com mailto:notifications@github.com<mailto:notifications@github.com mailto:notifications@github.com>> wrote:

Thanks Max! These plugins (pt and pp) are both very useful.

Unfortunately, I just checked the 'Style Source' and it seems to always say 'document', even though I know for sure the style references another library. For example, you can try the Carbon Design theme from IBM (sketch://add-library/cloud/JaVzz). The 'tags' here are using styles from another library, yet they still say 'document'.

Sketch image: https://snipboard.io/li1PH3.jpg

Puzzle Publisher: https://snipboard.io/tiWBvV.jpg

Perhaps this is related to why I can't get the Element selector drop down working either (it only works on autoselect).

Thanks

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<https://github.com/ingrammicro/puzzle-publisher/issues/11?email_source=notifications&email_token=AEMQVAU3QPXBY5MOWVXK66DQV727JA5CNFSM4JSXBUGKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H4XNMJA https://github.com/ingrammicro/puzzle-publisher/issues/11?email_source=notifications&email_token=AEMQVAU3QPXBY5MOWVXK66DQV727JA5CNFSM4JSXBUGKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H4XNMJA>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEMQVATFW77LG3SPMHOZGQTQV727JANCNFSM4JSXBUGA https://github.com/notifications/unsubscribe-auth/AEMQVATFW77LG3SPMHOZGQTQV727JANCNFSM4JSXBUGA>.

If you do not wish to receive promotional materials from Ingram Micro via e-mail, please go to http://www.ingrammicro.com/emailmgmt http://www.ingrammicro.com/emailmgmt or reply to this message and type unsubscribe in the subject.

Ingram Micro Inc. Corporate Headquarters, 3351 Michelson Drive, Suite 100, Irvine, CA 92612

This email may contain material that is confidential, and proprietary to Ingram Micro, for the sole use of the intended recipient. Any review, reliance or distribution by others or forwarding without express permission is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. [Ingram_2818e5de] — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. — You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ingrammicro/puzzle-publisher/issues/11?email_source=notifications&email_token=AEMQVAQDSGMTJZHRZMQ4AS3QWCBO5A5CNFSM4JSXBUGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFNYAKI#issuecomment-559644713, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEMQVATYU3FTN26KSBJPXY3QWCBO5ANCNFSM4JSXBUGA.

josh-tt commented 4 years ago

Actually, perhaps related is that I just discovered that when trying to import styles into PT into the Carbon theme, I'm getting an error:

Found multiply text styles with name 'heading-01 / text-02' etc....

Read SASS: running... /usr/local/lib/node_modules/sass Failed to parse SASS with error message:

I believe that this is because the theme is using styles with the same name, but from different libraries and perhaps PT doesn't know how to address that Thought I'd mention it here in case the problems are related. It could be user error (and I'll have to double check my code) but I could swear my PT scss was working in a previous version of PT.

MaxBazarov commented 4 years ago

It my fault. PP should show warnings in this case, but don’t stop a process. Fixed in 6.3.3 now.

On 4 Dec 2019, at 16:45, josh-tt notifications@github.com wrote:

Actually, perhaps related is that I just discovered that when trying to import styles into PT into the Carbon theme, I'm getting an error:

Found multiply text styles with name 'heading-01 / text-02' etc....

Read SASS: running... /usr/local/lib/node_modules/sass Failed to parse SASS with error message:

I believe that this is because the theme is using styles with the same name, but from different libraries and perhaps PT doesn't know how to address that Thought I'd mention it here in case the problems are related. It could be user error (and I'll have to double check my code) but I could swear my PT scss was working in a previous version of PT.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ingrammicro/puzzle-publisher/issues/11?email_source=notifications&email_token=AEMQVAQPDQKQVKDX2FNVMEDQW6X7XA5CNFSM4JSXBUGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF5CC3Y#issuecomment-561652079, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEMQVAVSA5C2N6QR54BLDKDQW6X7XANCNFSM4JSXBUGA.

josh-tt commented 4 years ago

Hmm, I'm afraid it's still not working.

  1. Opened the Carbon theme (https://sketch.cloud/s/JaVzz)
  2. Exported the html
  3. Viewed the 'Tags' page (which I know has the tag color backgrounds that point to another external library) and they still say 'document' as the source.
MaxBazarov commented 4 years ago

Yes. I din’t fix it yet.

Maxim Bazarov Senior UX Designer, User Experience and Design, Ingram Micro Cloud (office) ) +7-495-123-4623 | (mobile) +7-905-780-67-34 Leningradsky Ave 15с18, Moscow, 125040

[cid:clip_image001.png]

Twitterhttp://bit.ly/IngramTwitter | LinkedInhttp://bit.ly/IngramLinkedIN | Facebookhttp://bit.ly/IngramFacebook | YouTubehttp://bit.ly/IngramYouTube

On 4 Dec 2019, at 20:46, josh-tt notifications@github.com<mailto:notifications@github.com> wrote:

Hmm, I'm afraid it's still not working.

  1. Opened the Carbon theme (https://sketch.cloud/s/JaVzz)
  2. Exported the html
  3. Viewed the 'Tags' page (which I know has the tag color backgrounds that point to another external library) and they still say 'document' as the source.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/ingrammicro/puzzle-publisher/issues/11?email_source=notifications&email_token=AEMQVAUJKCLT4I5NUGAJFQLQW7UHPA5CNFSM4JSXBUGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF543LQ#issuecomment-561761710, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEMQVASAJK5XQFSOVWCHRHTQW7UHPANCNFSM4JSXBUGA.

If you do not wish to receive promotional materials from Ingram Micro via e-mail, please go to http://www.ingrammicro.com/emailmgmt or reply to this message and type unsubscribe in the subject.

Ingram Micro Inc. Corporate Headquarters, 3351 Michelson Drive, Suite 100, Irvine, CA 92612

This email may contain material that is confidential, and proprietary to Ingram Micro, for the sole use of the intended recipient. Any review, reliance or distribution by others or forwarding without express permission is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. [Ingram_2818e5de]

josh-tt commented 4 years ago

Oops sorry! Thought I was meant to check the latest :)

Sent from my iPhone

On Dec 5, 2019, at 3:36 PM, Maxim Bazarov notifications@github.com wrote:

Yes. I din’t fix it yet.

Maxim Bazarov Senior UX Designer, User Experience and Design, Ingram Micro Cloud (office) ) +7-495-123-4623 | (mobile) +7-905-780-67-34 Leningradsky Ave 15с18, Moscow, 125040

[cid:clip_image001.png]

Twitterhttp://bit.ly/IngramTwitter | LinkedInhttp://bit.ly/IngramLinkedIN | Facebookhttp://bit.ly/IngramFacebook | YouTubehttp://bit.ly/IngramYouTube

On 4 Dec 2019, at 20:46, josh-tt notifications@github.com<mailto:notifications@github.com> wrote:

Hmm, I'm afraid it's still not working.

  1. Opened the Carbon theme (https://sketch.cloud/s/JaVzz)
  2. Exported the html
  3. Viewed the 'Tags' page (which I know has the tag color backgrounds that point to another external library) and they still say 'document' as the source.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/ingrammicro/puzzle-publisher/issues/11?email_source=notifications&email_token=AEMQVAUJKCLT4I5NUGAJFQLQW7UHPA5CNFSM4JSXBUGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF543LQ#issuecomment-561761710, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEMQVASAJK5XQFSOVWCHRHTQW7UHPANCNFSM4JSXBUGA.

If you do not wish to receive promotional materials from Ingram Micro via e-mail, please go to http://www.ingrammicro.com/emailmgmt or reply to this message and type unsubscribe in the subject.

Ingram Micro Inc. Corporate Headquarters, 3351 Michelson Drive, Suite 100, Irvine, CA 92612

This email may contain material that is confidential, and proprietary to Ingram Micro, for the sole use of the intended recipient. Any review, reliance or distribution by others or forwarding without express permission is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. [Ingram_2818e5de] — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

MaxBazarov commented 4 years ago

Ok, I tried to resolve it in latest 11.6.1 update. Please validate

josh-tt commented 4 years ago

Seems to be working, nice one! Really helpful feature. Thanks Max