ingrammicro / puzzle-publisher

A Sketch plugin that exports Sketch artboards into clickable HTML file and publishes it on an external site.
GNU General Public License v3.0
174 stars 19 forks source link

Scrollbars show on modal dialogs #12

Closed zandermax closed 4 years ago

zandermax commented 4 years ago

When using an artboard as a modal dialog to display over another artboard, a scrollbar is shown when the generated files are viewed in a web browser, even when the content in the modal artboard is much smaller than the artboard being covered. The artboard for the modal dialog is sized to fit the content it contains, so this should not happen.

This happens in both Firefox and Chrome on Mac OS X.

Options selected for the art board:

Custom dimensions are not set for the artboard HTML export. The original artboards (that are covered by the modal dialogs) are 1370px x 1024px (WxH), and they are configured as regular pages, with "Scroll browser page to top" checked. However, the scrollbars still show if the underlying artboards are resized.

If the CSS "overflow-y" property is removed on the ".contentModal" class, the scrollbar goes away and the content fits as expected.

MaxBazarov commented 4 years ago

Thanks for report. I will fix it.

On 5 Dec 2019, at 01:57, Zander Maxwell notifications@github.com wrote:

When using an artboard as a modal dialog to display over another artboard, a scrollbar is shown when the generated files are viewed in a web browser, even when the content in the modal artboard is much smaller than the artboard being covered. The artboard for the modal dialog is sized to fit the content it contains, so this should not happen.

This happens in both Firefox and Chrome on Mac OS X.

Options selected for the art board:

"Show modal dialog or overlay shadow" - checked "Scroll browser page to top" - checked No delay time is set. Custom dimensions are not set for the artboard HTML export. The original artboards (that are covered by the modal dialogs) are 1370px x 1024px (WxH), and they are configured as regular pages, with "Scroll browser page to top" checked. However, the scrollbars still show if the underlying artboards are resized.

If the CSS "overflow-y" property is removed on the ".contentModal" class, the scrollbar goes away and the content fits as expected.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ingrammicro/puzzle-publisher/issues/12?email_source=notifications&email_token=AEMQVAXEURFNS2DGAWW7WC3QXAYUFA5CNFSM4JVQT6NKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H6EXZVQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEMQVASE65I7LH4WZYU44GDQXAYUFANCNFSM4JVQT6NA.

MaxBazarov commented 4 years ago

Fixed in 11.6.1