search

ingrammicro / puzzle-publisher

A Sketch plugin that exports Sketch artboards into clickable HTML file and publishes it on an external site.
GNU General Public License v3.0
174 stars 19 forks source link

Async pre-loading of all page images #9

Closed nickian closed 5 years ago

nickian commented 5 years ago

Loving this plugin so far. Thanks for the work.

Can this type of loading be an optional feature? I personally do not like having the image fully displayed and fuzzy while it's loading. The browser does not appear to be in a loading state while the document is loading. So if you're loading a large document that takes a long time, it can confuse people to think that they are simply looking at a bad quality mockup.

Another suggestion would maybe be a more dramatic and obvious "loading" icon than what is currently in the bottom right corner.

MaxBazarov commented 5 years ago

Loving this plugin so far. Thanks for the work.

Thanks for feedback!

Can this type of loading be an optional feature?

Sure. I can make it. But I'm not sure that I understand you problem correctly. Could you write a video to show how it looks for you?

nickian commented 5 years ago

Here is a screenshot example. I just exported a few random large images to show what is happening.

When first opening the page, you see this pixelated (still loading) version of the artboard. You can see it's pretty pixelated:

image1

After like 30 seconds it finishes loading and looks clear:

image2

But it's not super obvious that the image is still loading, so it's slightly confusing to see the pixelated image for a while. I think a progress bar would be the most useful with the async loading.

MaxBazarov commented 5 years ago

Actually you can open your page without images async loading if you add “?embed” to your URL.

https://mysite.com/myproject/live/ => https://mysite.com/myproject/live/?embed

In this mode async loading is disabled. Could you try it to see how it will be change your situation?

Thanks

On 15 Nov 2019, at 23:44, Nick notifications@github.com<mailto:notifications@github.com> wrote:

Here is a screenshot example. I just exported a few random large images to show what is happening.

When first opening the page, you see this pixelated (still loading) version of the artboard. You can see it's pretty pixelated:

[image1]https://user-images.githubusercontent.com/590678/68972761-c12c6100-07a9-11ea-9464-2f5c2c7f3e17.jpg

After like 30 seconds it finishes loading and looks clear:

[image2]https://user-images.githubusercontent.com/590678/68972801-dbfed580-07a9-11ea-8bae-8f6264d04190.jpg

But it's not super obvious that the image is still loading, so it's slightly confusing to see the pixelated image for a while. I think a progress bar would be the most useful with the async loading.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/ingrammicro/puzzle-publisher/issues/9?email_source=notifications&email_token=AEMQVAXLXITKNULVRSUDWJDQT4C23A5CNFSM4JNSWD72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEGVGKA#issuecomment-554521384, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEMQVATSA7UKUGY726C5253QT4C23ANCNFSM4JNSWD7Q.

If you do not wish to receive promotional materials from Ingram Micro via e-mail, please go to http://www.ingrammicro.com/emailmgmt or reply to this message and type unsubscribe in the subject.

Ingram Micro Inc. Corporate Headquarters, 3351 Michelson Drive, Suite 100, Irvine, CA 92612

This email may contain material that is confidential, and proprietary to Ingram Micro, for the sole use of the intended recipient. Any review, reliance or distribution by others or forwarding without express permission is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. [Ingram_2818e5de]

nickian commented 5 years ago

Oh ok, thanks. I don't see a big difference, but maybe it's just the way the browser loads images regardless of the async.