search

ingrammicro / puzzle-tokens

Batch create, manage and update Sketch styles and symbols using SCSS/LESS
GNU General Public License v3.0
92 stars 17 forks source link

Generate Style Overview - Bug #12

Closed tamcao closed 5 years ago

tamcao commented 5 years ago

Love the new Generate Style Overview feature in the latest release. When I generated the style, I did noticed that it added two extra characters to the Hex value as well as a border color to the label text. https://drive.google.com/file/d/1WQ9nrBDClYtKZj40pOrfpOZ7nFisafPB

MaxBazarov commented 5 years ago

Ok, checking...

MaxBazarov commented 5 years ago

Fixed in 6.2.1

tamcao commented 5 years ago

Fixed in 6.2.1

I just ran a test, and the latest update did fixes the issues mentioned πŸ™Œ. Did notice there is another bug in the style generation where the text has an opacity value. The generated hex value for those still has two extra characters for some reason.

ie. .text-example { font-family: BentonSans-Regular; font-size: 21px; color: rgba(110,85,161,0.38); letter-spacing: 0; text-align: right; line-height: 28px; } current hex rendered output:

6E55A161 <--extra '61' at the end

MaxBazarov commented 5 years ago

It’s how Sketch reports text color. Why do you want to drop valued opacity here?

Maxim Bazarov Senior UX Designer, User Experience and Design, Ingram Micro Cloud (office) ) +7-495-123-4623 | (mobile) +7-905-780-67-34 Leningradsky Ave 15с18, Moscow, 125040

[cid:clip_image001.png]

Twitterhttp://bit.ly/IngramTwitter | LinkedInhttp://bit.ly/IngramLinkedIN | Facebookhttp://bit.ly/IngramFacebook | YouTubehttp://bit.ly/IngramYouTube

On 21 Nov 2019, at 17:29, Tam Cao notifications@github.com<mailto:notifications@github.com> wrote:

Fixed in 6.2.1

I just ran a test, and the latest update did fixes the issues mentioned πŸ™Œ. Did notice there is another bug in the style generation where the text has an opacity value. The generated hex value for those still has two extra characters for some reason.

ie. .text-example { font-family: BentonSans-Regular; font-size: 21px; color: rgba(110,85,161,0.38); letter-spacing: 0; text-align: right; line-height: 28px; } current hex rendered output:

6E55A161 <--extra '61' at the end

β€” You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/ingrammicro/puzzle-tokens/issues/12?email_source=notifications&email_token=AEMQVAV4DLDW37OX5IWSXYLQU2LNFA5CNFSM4JPJRRCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE2NDEA#issuecomment-557109648, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEMQVAWDNT3IDT2TS3JXHSTQU2LNFANCNFSM4JPJRRCA.

If you do not wish to receive promotional materials from Ingram Micro via e-mail, please go to http://www.ingrammicro.com/emailmgmt or reply to this message and type unsubscribe in the subject.

Ingram Micro Inc. Corporate Headquarters, 3351 Michelson Drive, Suite 100, Irvine, CA 92612

This email may contain material that is confidential, and proprietary to Ingram Micro, for the sole use of the intended recipient. Any review, reliance or distribution by others or forwarding without express permission is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. [Ingram_2818e5de]

tamcao commented 5 years ago

Oh ok. I was trying to reproduce a text legibility scenario similar to the way Material Design's recommendation for dark text on light backgrounds. https://material.io/design/color/text-legibility.html#text-backgrounds