search

ingrammicro / puzzle-tokens

Batch create, manage and update Sketch styles and symbols using SCSS/LESS
GNU General Public License v3.0
92 stars 17 forks source link

Fix typo in nsconvert_sass.js #18

Closed achinchen closed 4 years ago

achinchen commented 4 years ago

Thanks for this nice plugin. My designer colleague loves to use it 😊

But after updating, she found an error caused unhandled exception. I looked around in lib/nsconvert_less is fine, but sass one isn't. Therefore, I tried to fix it, hope it work!

If this pr needs to be modified, please leave a comment let me know, and fix it πŸ˜… However, This is a nice project πŸŽ‰

Have a nice day.

MaxBazarov commented 4 years ago

Shame on me! Will release new update in two hours.

13 дСк. 2019 г., в 05:34, CHC notifications@github.com написал(а):

 Thanks for this nice plugin. My designer colleague loves to use it 😊

But after updating, she found an error caused unhandled exception. I looked around in lib/nsconvert_less is fine, but sass one isn't. I try to fix it, hope it work!

If this pr needs to be modified, please leave comment let me know, and fix it πŸ˜… However, This is a nice project πŸŽ‰

Have a nice day.

You can view, comment on, or merge this pull request online at:

https://github.com/ingrammicro/puzzle-tokens/pull/18

Commit Summary

Fix typo in nsconvert_sass.js File Changes

M PuzzleTokens.sketchplugin/Contents/Sketch/scripts/nsconvert_sass.js (280) Patch Links:

https://github.com/ingrammicro/puzzle-tokens/pull/18.patch https://github.com/ingrammicro/puzzle-tokens/pull/18.diff β€” You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

MaxBazarov commented 4 years ago

Fixed in 6.5.1