search

ingwinlu / python-twitch

python-twitch is an python module for simple interaction with twitch.
http://ingwinlu.github.io/python-twitch/
GNU General Public License v3.0
34 stars 17 forks source link

Replace urllib(2) and JSONScraper with requests #2

Closed zoidyzoidzoid closed 10 years ago

zoidyzoidzoid commented 10 years ago

Would you consider using the requests library?

The requests library would clean up a lot of the code, by not needing the JSONScraper, as it has a requests.get(<url>).json().

I'd be happy to make a PR adding it.

ingwinlu commented 10 years ago

Hey @zoidbergwill, while this is an excellent idea because of a lot of reasons (speed up because don't need to catch ImportErrors, readability, complexity...) it is an additional dependency which would need to be installed.

Most code of this project is also used in the project it has been forked from, which is an XBMC Plugin. To my knowledge it is not possible to let XBMC handle library installation.

So far this has been enough of a reason for me to let it like it is right now.

zoidyzoidzoid commented 10 years ago

Hey @ingwinlu

I considered maybe the reason no dependencies were being used may have something to do with XBMC.

Thanks for clearing that up.