search

ingwinlu / python-twitch

python-twitch is an python module for simple interaction with twitch.
http://ingwinlu.github.io/python-twitch/
GNU General Public License v3.0
34 stars 17 forks source link

Fix this for python 3 #27

Closed shughes-uk closed 8 years ago

shughes-uk commented 8 years ago

There is no readall() for python 3 , read() is what you need

shughes-uk commented 8 years ago

No idea why this is failing on python2.7 when no changes that should affect it have been commited

ingwinlu commented 8 years ago

did not see this one first, see my response in https://github.com/ingwinlu/python-twitch/pull/28

ingwinlu commented 8 years ago

Also you should never open PR's from your master branch. It is a recipe for disaster and makes rebasing a lot more complicated.

ingwinlu commented 8 years ago

closed in favour of #28