search

ingwinlu / python-twitch

python-twitch is an python module for simple interaction with twitch.
http://ingwinlu.github.io/python-twitch/
GNU General Public License v3.0
34 stars 17 forks source link

Make compatible with python3.5 #28

Closed panzi closed 8 years ago

panzi commented 8 years ago

Its response.read() in Python 3 just like in Python 2.

ingwinlu commented 8 years ago

That is not a python3 issue, it is specific to >=python3.5. If you update your commit message to include a better description of the cause I will happily merge it. Else I will push one myself.

ingwinlu commented 8 years ago

See https://travis-ci.org/ingwinlu/python-twitch/builds/100302785 for confirmation.

panzi commented 8 years ago

Like this?

ingwinlu commented 8 years ago

https://github.com/erlang/otp/wiki/Writing-good-commit-messages or http://chris.beams.io/posts/git-commit/ give good ideas on how commit messages should be written.

I would go for something like:

Replace .readall with .read for HTTPResponse object

Python 3.5 removed .readall from HTTPresponse objects. The 
same effect can be archived with .read.
ingwinlu commented 8 years ago

ty