search

ingwinlu / python-twitch

python-twitch is an python module for simple interaction with twitch.
http://ingwinlu.github.io/python-twitch/
GNU General Public License v3.0
34 stars 17 forks source link

Update __init__.py #3

Closed MrSprigster closed 9 years ago

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.02%) to 96.11% when pulling 737873a06d68e330e73aad730cc0a9cf8ac7ed49 on MrSprigster:patch-1 into 866e4693f1c680d10c0f0420440f1b08c5b0bee9 on ingwinlu:master.

ingwinlu commented 9 years ago

already cherrypicked your commit from upstream :)

MrSprigster commented 9 years ago

Cool :+1: :)

ingwinlu commented 9 years ago

the problem with that solution is that it isn't best match anymore, it just gets the best available resolution instead of the closest one to what you want

MrSprigster commented 9 years ago

That's true but at the moment it seems to be a boolean, Twitch either provides transcoding (to all qualities) or none (just provides source).

ingwinlu commented 9 years ago

don't forget about restricted streams though

MrSprigster commented 9 years ago

Ideally (due to current lack of user auth) restricted qualities should be ignored and never reach the getQuality function.

They are defined as EXT-X-TWITCH-RESTRICTED and the lines that contained this were dropped in previous versions.

Sprig

MrSprigster commented 9 years ago

And it looks like they still are :)

if(line.startswith('#EXT-X-MEDIA')):

ingwinlu commented 9 years ago

@MrSprigster do you mind reviewing #5?