rework quality - Githubissues

ingwinlu / python-twitch

python-twitch is an python module for simple interaction with twitch.

http://ingwinlu.github.io/python-twitch/

GNU General Public License v3.0

34 stars 17 forks source link

rework quality #5

Closed ingwinlu closed 9 years ago

ingwinlu commented 9 years ago

rework how qualities in M3UPlaylist are handled.

find best match quality over distance between selected/available qualities
make sure playlist has at least one parsed value else throw an ValueError
add test for valueerror

coveralls commented 9 years ago

Coverage decreased (-1.45%) to 94.66% when pulling a1ee4ba4da512e654a8d5b8043d0d4ba05dd587d on rework_quality into 0a9dbdf1ad1e5aa89c84958258f1f7e8cdb5696b on master.

coveralls commented 9 years ago

Coverage decreased (-1.45%) to 94.66% when pulling 9464750e160381a65a90cd011e9fd5e824251a38 on rework_quality into 0a9dbdf1ad1e5aa89c84958258f1f7e8cdb5696b on master.

coveralls commented 9 years ago

Coverage decreased (-0.31%) to 95.8% when pulling 2b1c233cb2146774c85195ecaa7ecad225a54f66 on rework_quality into 0a9dbdf1ad1e5aa89c84958258f1f7e8cdb5696b on master.

MrSprigster commented 9 years ago

Looks good to me.

coveralls commented 9 years ago

Coverage decreased (-0.31%) to 95.8% when pulling f9a5ca1b42d30963b43ea4d912e7a3a4595c938d on rework_quality into 0a9dbdf1ad1e5aa89c84958258f1f7e8cdb5696b on master.

MrSprigster commented 9 years ago

Is there currently an instance where the nearest available quality will be used as opposed to the best available?

coveralls commented 9 years ago

Coverage decreased (-0.31%) to 95.8% when pulling 00ffd5f08a422d8d7e98075096d3a73d332a5a62 on rework_quality into 0a9dbdf1ad1e5aa89c84958258f1f7e8cdb5696b on master.

ingwinlu commented 9 years ago

@MrSprigster you mean a test case like this: 3937f48 ?

on a more general note: i am not aware if twitch ever produces such output, i.e. restricting lower qualities but offering better ones without.

i am hesitant to just deliver the 'best' available quality in such a case though, since if you selected a lower quality you do that because you have a reason to, so an available lower quality is probably prefered to a good one

MrSprigster commented 9 years ago

It's definitely an advantage to have that ability within the addon just in case Twitch decides to start offering a wider range of qualities to streamers. However unfortunately I don't anticipate this enhancement being utilised any time soon simply due to the way Twitch does things :(.

:+1: for the good coding practice though. Hopefully Twitch will follow suit at some point.

Sprig

MrSprigster commented 9 years ago

Drop me a pull request when you're ready and I'll merge.

Thanks again for your work on this,

Sprig :100: