Initial patchset for integration with debian

spog commented 3 weeks ago

In the process of preparing a debian git-subrepo package, a set of changes had to be prepared to adapt git-subrepo to debian runtime and build system requirements. Changes have been grouped as follows:

Removed hashbangs from sourced-only files (debian policy)
Removed executable permission on sourced-only files (debian policy)
Fixed bash-completion integration with git (git sub[tab][tab] did not find subrepo)
Drop unnecessary subdir in usr/share/git-subrepo (only for 'make install' installation method)
Fixed 'make test' for debian build (debian build of package runs from a non-git git-subrepo project and for different languages)
Generate test git-repos instead of committed binaries (i prefer text files in a git project whenever possible)

admorgan commented 2 weeks ago

I am in the middle of tracking down a couple of annoying bugs. The intentions of this patch look reasonable, but it may be a bit before I dig in and determine if I can approve it. This is largely due to the fact the bugs I am tracking down are caught by our CI and therefore it makes it harder to test these changes.

spog commented 2 weeks ago

Thanks for the reply and take your time:)

spog commented 4 days ago

@admorgan Hi, and thanks for the review. i am currently on vacation until the end of July. I hope we can proceed then. regards, Samo

ingydotnet / git-subrepo

Initial patchset for integration with debian #623