search

ingydotnet / inline-c-pm

10 stars 19 forks source link

Fix Include Dir Behavior, Replace -I With -iquote #73

Closed wbraswell closed 5 years ago

wbraswell commented 5 years ago

Fix for bug https://github.com/ingydotnet/inline-c-pm/issues/72

mohawk2 commented 5 years ago

Am I right that -iquote is a GCC-only flag, and therefore will break Inline::C for anyone not using GCC?

wbraswell commented 5 years ago

@mohawk2 no, you are not correct https://github.com/ingydotnet/inline-c-pm/issues/72#issuecomment-451359214

mohawk2 commented 5 years ago

So I have just seen. That justification should be put here. I do not think breaking Inline::C on even one known compiler is justified by the problem you've just discovered.

wbraswell commented 5 years ago

@mohawk2 We are not breaking Inline::C on any compilers. Please try to keep up with the conversation, and leave your negativity at the door, thanks! https://github.com/ingydotnet/inline-c-pm/issues/72#issuecomment-451514532

wbraswell commented 5 years ago

replaced by new MS-friendly pull request https://github.com/ingydotnet/inline-c-pm/pull/74

sisyphus commented 5 years ago

William,

I'll merge the pull request (#74) tomorrow if no-one has requested any modifications to it. I wonder if we might discover other cases where '-iquote' is not being handled correctly. If no-one volunteers information about the existence of these "other cases", then I can think of only one way to find out ;-)

Cheers, Rob

On Sun, Jan 6, 2019 at 7:20 AM William N. Braswell, Jr. < notifications@github.com> wrote:

replaced by new MS-friendly pull request

74 https://github.com/ingydotnet/inline-c-pm/pull/74

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ingydotnet/inline-c-pm/pull/73#issuecomment-451687406, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEdvHn7yxHcQwCeVzmKLZvM14t-n-QLks5vAQjwgaJpZM4ZpLgD .